Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated SerialConsoleLogger from the MSBuild codebase, simplifying the logging architecture by consolidating to only use the ParallelConsoleLogger.
- Removes the SerialConsoleLogger class and all references to it
- Updates ConsoleLogger to always use ParallelConsoleLogger instead of choosing between Serial and Parallel loggers
- Removes documentation and localized text about the DisableMPLogging parameter
- Cleans up test files that were testing SerialConsoleLogger functionality
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Build/Logging/SerialConsoleLogger.cs | Complete removal of the SerialConsoleLogger class (981 lines) |
| src/Build/Microsoft.Build.csproj | Removes SerialConsoleLogger.cs from the project compilation |
| src/Build/Logging/ConsoleLogger.cs | Simplifies logger initialization to always use ParallelConsoleLogger |
| src/UnitTests.Shared/EngineTestEnvironment.cs | Removes SerialConsoleLogger from test environment setup |
| src/MSBuild/XMake.cs | Removes condition checking for DisableMPLogging parameter |
| src/MSBuild/Resources/*.xlf | Removes localized documentation for DisableMPLogging parameter |
| src/Build.UnitTests/ConsoleLogger_Tests.cs | Removes all SerialConsoleLogger test cases and references |
| src/Build.UnitTests/BinaryLogger_Tests.cs | Removes SerialConsoleLogger from binary logger roundtrip tests |
| src/Build/Logging/ParallelLogger/ParallelConsoleLogger.cs | Minor formatting change (adds blank line) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
YuliiaKovalova
force-pushed
the
dev/ykovalova/remove_SerialConsoleLogger
branch
from
0a5ec66 to
baa4ac7
Compare
YuliiaKovalova
force-pushed
the
dev/ykovalova/remove_SerialConsoleLogger
branch
from
82391c2 to
3e7c934
Compare
Member
Author
Member
Author
1 test failure due to changes in the spaces , other than that we are ready to proceed. |
JanProvaznik
approved these changes
Aug 19, 2025
surayya-MS
approved these changes
Aug 20, 2025
YuliiaKovalova
added a commit
to dotnet/sdk
that referenced
this pull request
Aug 22, 2025
The change is related to SerialConsoleLogger deprecation: dotnet/msbuild#12336
JanProvaznik
pushed a commit
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ##2447
Context
The deprecation of the logger was approved internally: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2511087?src=WorkItemMention&src-action=artifact_link
Changes Made
Remove SerialConsoleLogger from the codebase